refactor(chore): remove Node js 20 support#23
Conversation
rohit-sourcefuse
left a comment
rohit-sourcefuse
left a comment
There was a problem hiding this comment.
Node 20 removal and the workflow/matrix changes look clean. One thing to fix before merge: package.json sets engines.node to "22 || 24", but the regenerated package-lock.json root still has ">=22" — the lockfile was generated before the engines value was changed and not re-run. Re-run npm install so they match.
Suggestion: standardize on ">=22" for a published library — "22 || 24" excludes Node 23 and every future LTS (26, 28…), so the package would refuse to install on the next LTS until another bump. Don't over-constrain consumers. Checks are green otherwise.
remove Node js 20 support BREAKING CHANGE: yes GH-22
SonarQube reviewer guideSummary: Upgrade project to support Node.js 22 and 24, updating dependencies and improving ecosystem compatibility. Review Focus:
Start review at:
|
rohit-sourcefuse
left a comment
rohit-sourcefuse
left a comment
There was a problem hiding this comment.
Engines and lockfile now match (22 || 24 both sides) and all checks are green. Approving — thanks for the quick turnaround.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
remove Node js 20 support
BREAKING CHANGE:
yes
GH-22
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Checklist:
Build:
Test: